Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fixing express example #573

Merged
merged 1 commit into from Jul 16, 2021
Merged

chore: fixing express example #573

merged 1 commit into from Jul 16, 2021

Conversation

obecny
Copy link
Member

@obecny obecny commented Jul 15, 2021

express example doesn't have service name

@obecny obecny added the bug Something isn't working label Jul 15, 2021
@obecny obecny requested a review from a team as a code owner July 15, 2021 18:45
@codecov
Copy link

codecov bot commented Jul 15, 2021

Codecov Report

Merging #573 (641391c) into main (9dabf39) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 641391c differs from pull request most recent head 9d34c19. Consider uploading reports for the commit 9d34c19 to get more accurate results

@@            Coverage Diff             @@
##             main     #573      +/-   ##
==========================================
- Coverage   94.77%   94.75%   -0.02%     
==========================================
  Files         179      169      -10     
  Lines       10946    10724     -222     
  Branches     1086     1066      -20     
==========================================
- Hits        10374    10162     -212     
+ Misses        572      562      -10     
Impacted Files Coverage Δ
...ction/src/contentScript/InstrumentationInjector.ts
...er-extension-autoinjection/test/background.test.ts
...rc/background/ProgrammaticContentScriptInjector.ts
...er-extension-autoinjection/src/background/index.ts
...tension-autoinjection/test/instrumentation.test.ts
...etry-browser-extension-autoinjection/test/utils.ts
...metry-browser-extension-autoinjection/src/types.ts
...njection/src/instrumentation/WebInstrumentation.ts
...extension-autoinjection/src/contentScript/index.ts
...extension-autoinjection/test/contentScript.test.ts

@obecny
Copy link
Member Author

obecny commented Jul 16, 2021

restarting CLA

@obecny obecny closed this Jul 16, 2021
@obecny obecny reopened this Jul 16, 2021
@obecny obecny merged commit 9668b42 into open-telemetry:main Jul 16, 2021
@obecny obecny deleted the express branch July 16, 2021 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants