Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: use single quotes everywhere and add a rule to eslint #583

Merged
merged 2 commits into from Jul 26, 2021

Conversation

CptSchnitz
Copy link
Contributor

Which problem is this PR solving?

Short description of the changes

  • Added ESlint rule for single quote
  • Ran ESlint:fix on the entire repo
  • Went over the README's and changed to single quotes there
  • fixed single quotes in scripts

(There's also eslint.config.js itself, but I wasn't sure if everywhere includes it, tell me if I should also edit it)

@CptSchnitz CptSchnitz requested a review from a team as a code owner July 20, 2021 18:01
@CptSchnitz
Copy link
Contributor Author

So it failed the test because of a package that came out a few minutes ago (@babel/parser):
image

that's interesting 😅

@rauno56
Copy link
Member

rauno56 commented Jul 20, 2021

It's probably just bad timing. @babel/core was published, the dependency was not.
Trigger new CI run with an empty commit git commit --allow-empty.

@vmarchaud
Copy link
Member

i've restarted the build myself but you should be able to do it if you go on the build page (by clicking on either tasks) and click on "Restart all jobs" on something like this at the top right

@codecov
Copy link

codecov bot commented Jul 21, 2021

Codecov Report

Merging #583 (909901d) into main (e27bda4) will not change coverage.
The diff coverage is n/a.

❗ Current head 909901d differs from pull request most recent head 505dfb7. Consider uploading reports for the commit 505dfb7 to get more accurate results

@@           Coverage Diff           @@
##             main     #583   +/-   ##
=======================================
  Coverage   94.78%   94.78%           
=======================================
  Files         179      179           
  Lines       10976    10976           
  Branches     1088     1088           
=======================================
  Hits        10404    10404           
  Misses        572      572           

@CptSchnitz
Copy link
Contributor Author

When i look at my own repos, i have a button that says "re-run jobs",
but it doesn't show up here.

@obecny obecny merged commit 68e5449 into open-telemetry:main Jul 26, 2021
@CptSchnitz CptSchnitz deleted the issue-582 branch July 26, 2021 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants