Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add missing fetch instrumentation #622

Merged
merged 2 commits into from Aug 19, 2021
Merged

Conversation

meteorlxy
Copy link
Contributor

Which problem is this PR solving?

  • add missing link to @opentelemetry/instrumentation-fetch package

Short description of the changes

  • add missing link to @opentelemetry/instrumentation-fetch package

@meteorlxy meteorlxy requested a review from a team as a code owner August 16, 2021 17:06
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Aug 16, 2021

CLA Signed

The committers are authorized under a signed CLA.

Copy link
Member

@obecny obecny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov
Copy link

codecov bot commented Aug 16, 2021

Codecov Report

Merging #622 (1bac840) into main (979d69b) will decrease coverage by 0.81%.
The diff coverage is n/a.

❗ Current head 1bac840 differs from pull request most recent head 5eb640f. Consider uploading reports for the commit 5eb640f to get more accurate results

@@            Coverage Diff             @@
##             main     #622      +/-   ##
==========================================
- Coverage   97.50%   96.68%   -0.82%     
==========================================
  Files          10       13       +3     
  Lines         360      634     +274     
  Branches       56      124      +68     
==========================================
+ Hits          351      613     +262     
- Misses          9       21      +12     
Impacted Files Coverage Δ
...ation-user-interaction/src/enums/AttributeNames.ts 100.00% <0.00%> (ø)
...umentation-user-interaction/src/instrumentation.ts 95.48% <0.00%> (ø)
...ry-instrumentation-user-interaction/src/version.ts 100.00% <0.00%> (ø)

@blumamir
Copy link
Member

BTW, node list also has many missing instrumentations if you're up to it. Can also be added in a different PR

Copy link
Member

@johnbley johnbley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@obecny obecny merged commit ecde944 into open-telemetry:main Aug 19, 2021
@obecny obecny added the enhancement New feature or request label Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants