From 62c11b43412f1184335d048b579ab5fb46dc0711 Mon Sep 17 00:00:00 2001 From: Ali Sabzevari Date: Thu, 8 Jul 2021 18:43:49 +0200 Subject: [PATCH] fix(exporter-collector): remove Readable.from for node8 compatibility --- .../src/platform/node/util.ts | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/packages/opentelemetry-exporter-collector/src/platform/node/util.ts b/packages/opentelemetry-exporter-collector/src/platform/node/util.ts index 2773824a498..ff794ea09d4 100644 --- a/packages/opentelemetry-exporter-collector/src/platform/node/util.ts +++ b/packages/opentelemetry-exporter-collector/src/platform/node/util.ts @@ -83,7 +83,7 @@ export function sendWithHttp( }); if (compress) { - const dataStream = Readable.from(data); + const dataStream = readableFromBuffer(data); pipeline(dataStream, gzip, req, onGzipError(onError)); } else { req.write(data); @@ -91,6 +91,14 @@ export function sendWithHttp( } } +function readableFromBuffer(buff: string | Buffer): Readable { + const readable = new Readable(); + readable.push(buff); + readable.push(null); + + return readable; +} + function onGzipError(onError: (error: collectorTypes.CollectorExporterError) => void) { return (err: NodeJS.ErrnoException | null) => { const error = new collectorTypes.CollectorExporterError(