From 963a3445c90670c68ac32c185879030db29b308b Mon Sep 17 00:00:00 2001 From: Aaron Abbott Date: Wed, 16 Jun 2021 17:52:11 +0000 Subject: [PATCH] chore: reword test descriptions --- .../test/CollectorExporterNodeBase.test.ts | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/packages/opentelemetry-exporter-collector-grpc/test/CollectorExporterNodeBase.test.ts b/packages/opentelemetry-exporter-collector-grpc/test/CollectorExporterNodeBase.test.ts index f878c7e3b6d..395d3f4b1e2 100644 --- a/packages/opentelemetry-exporter-collector-grpc/test/CollectorExporterNodeBase.test.ts +++ b/packages/opentelemetry-exporter-collector-grpc/test/CollectorExporterNodeBase.test.ts @@ -88,7 +88,7 @@ describe('CollectorExporterNodeBase', () => { // Mock that all requests finish sending exporter.sendCallbacks.forEach(({ onSuccess }) => onSuccess()); - // All finished promises should be dropped off + // All finished promises should be popped off await promisesAllDone; assert.strictEqual(exporter['_sendingPromises'].length, 0); }); @@ -106,12 +106,12 @@ describe('CollectorExporterNodeBase', () => { // Mock that all requests finish sending exporter.sendCallbacks.forEach(({ onSuccess }) => onSuccess()); - // All finished promises should be dropped off + // All finished promises should be popped off await promisesAllDone; assert.strictEqual(exporter['_sendingPromises'].length, 0); }); - it('should drop export requests even if they failed', async () => { + it('should pop export request promises even if they failed', async () => { const spans = [Object.assign({}, mockedReadableSpan)]; exporter.export(spans, () => {}); @@ -122,12 +122,12 @@ describe('CollectorExporterNodeBase', () => { onError(new Error('Failed to send!!')) ); - // All finished promises should be dropped off + // All finished promises should be popped off await promisesAllDone; assert.strictEqual(exporter['_sendingPromises'].length, 0); }); - it('should drop export requests even if success callback throws error', async () => { + it('should pop export request promises even if success callback throws error', async () => { const spans = [Object.assign({}, mockedReadableSpan)]; exporter['_sendPromise']( @@ -145,7 +145,7 @@ describe('CollectorExporterNodeBase', () => { onSuccess(); }); - // All finished promises should be dropped off + // All finished promises should be popped off await promisesAllDone; assert.strictEqual(exporter['_sendingPromises'].length, 0); });