Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ExportResult.FAILED_RETRYABLE isnt spec compliant #1569

Closed
vmarchaud opened this issue Oct 5, 2020 · 2 comments · Fixed by #1643
Closed

ExportResult.FAILED_RETRYABLE isnt spec compliant #1569

vmarchaud opened this issue Oct 5, 2020 · 2 comments · Fixed by #1643
Assignees
@vmarchaud
Projects
GA Burndown

Comments

@vmarchaud
Copy link
Member

Note: the spec declare that any retry logic should be handled by the exporter so the result FAILED_RETRYABLE isn't spec compliant currently.

Originally posted by @vmarchaud in #1561 (comment)
@vmarchaud vmarchaud self-assigned this Oct 5, 2020
@aabmass
Copy link
Member

aabmass commented Oct 6, 2020

Just to clarify, FAILED_RETRYABLE will be removed altogether?

@aabmass aabmass mentioned this issue Oct 6, 2020
Closed
@dyladan
Copy link
Member

dyladan commented Oct 6, 2020

Just to clarify, FAILED_RETRYABLE will be removed altogether?

I believe that is the desired end-state.

@dyladan dyladan added this to To do issues in GA Burndown via automation Oct 21, 2020
This was referenced Oct 22, 2020
Closed
Merged
This was referenced Oct 28, 2020
Closed
Merged
GA Burndown automation moved this from To do issues to Done Nov 4, 2020
dyladan added a commit that referenced this issue Nov 4, 2020
@vmarchaud @dyladan
refactor: new interface for ExportResult #1569 (#1643)
14c92da 
Co-authored-by: Daniel Dyla <dyladan@users.noreply.github.com>
pichlermarc added a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this issue Dec 15, 2023
@chigia001 @pichlermarc
feat(fastify): Skip update HTTP's span name and update RpcMetadata's …
8d9687d 
…route instead (open-telemetry#1569)

Co-authored-by: Marc Pichler <marc.pichler@dynatrace.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vmarchaud vmarchaud

Labels
None yet
Projects
No open projects
GA Burndown
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: new interface for ExportResult #1569 vmarchaud/opentelemetry-js
3 participants
@aabmass @dyladan @vmarchaud