Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert grpc plugin to instrumentation #1656

Closed
obecny opened this issue Nov 5, 2020 · 0 comments · Fixed by #1744
Closed

Convert grpc plugin to instrumentation #1656

obecny opened this issue Nov 5, 2020 · 0 comments · Fixed by #1744
Assignees
@vmarchaud
Labels
feature-request

Comments

@obecny
Copy link
Member

obecny commented Nov 5, 2020 •
edited by dyladan

  • Change folder name from opentelemetry-plugin-* to opentelemetry-instrumentation-*
  • Change package name from @opentelemetry/plugin-* to @opentelemetry/instrumentation-*
  • Change implementation to use InstrumentationBase
@obecny obecny added feature-request up-for-grabs Good for taking. Extra help will be provided by maintainers labels Nov 5, 2020
@vmarchaud vmarchaud self-assigned this Dec 5, 2020
@vmarchaud vmarchaud removed the up-for-grabs Good for taking. Extra help will be provided by maintainers label Dec 5, 2020
@vmarchaud vmarchaud mentioned this issue Dec 12, 2020
Closed
vmarchaud added a commit to vmarchaud/opentelemetry-js that referenced this issue Dec 12, 2020
@vmarchaud
feat(grpc-instrumentation): migrate grpc to instrumentation open-tele…
0054fde 
…metry#1656
vmarchaud added a commit to vmarchaud/opentelemetry-js that referenced this issue Dec 16, 2020
@vmarchaud
feat(grpc-instrumentation): migrate grpc to instrumentation open-tele…
2f0276b 
…metry#1656
vmarchaud added a commit to vmarchaud/opentelemetry-js that referenced this issue Dec 19, 2020
@vmarchaud
feat(grpc-instrumentation): migrate grpc to instrumentation open-tele…
9869a2f 
…metry#1656
@vmarchaud vmarchaud linked a pull request Dec 19, 2020 that will close this issue
feat(grpc-instrumentation): migrate grpc to instrumentation #1656 #1744
Merged
vmarchaud added a commit to vmarchaud/opentelemetry-js that referenced this issue Dec 27, 2020
@vmarchaud
feat(grpc-instrumentation): migrate grpc to instrumentation open-tele…
fcf9109 
…metry#1656
vmarchaud added a commit to vmarchaud/opentelemetry-js that referenced this issue Jan 5, 2021
@vmarchaud
feat(grpc-instrumentation): migrate grpc to instrumentation open-tele…
62e10ae 
…metry#1656
dyladan added a commit that referenced this issue Jan 6, 2021
@vmarchaud @dyladan
feat(grpc-instrumentation): migrate grpc to instrumentation #1656 (#1744
b4c9e40 
)

Co-authored-by: Daniel Dyla <dyladan@users.noreply.github.com>
dyladan added a commit to dyladan/opentelemetry-js that referenced this issue Sep 9, 2022
@vmarchaud @dyladan
feat(grpc-instrumentation): migrate grpc to instrumentation open-tele…
f3a2d74 
…metry#1656 (open-telemetry#1744)

Co-authored-by: Daniel Dyla <dyladan@users.noreply.github.com>
dyladan added a commit to dyladan/opentelemetry-js that referenced this issue Sep 9, 2022
@vmarchaud @dyladan
feat(grpc-instrumentation): migrate grpc to instrumentation open-tele…
f8fd50c 
…metry#1656 (open-telemetry#1744)

Co-authored-by: Daniel Dyla <dyladan@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vmarchaud vmarchaud

Labels
feature-request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(grpc-instrumentation): migrate grpc to instrumentation #1656 vmarchaud/opentelemetry-js
2 participants
@obecny @vmarchaud