Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Getting started typescript still uses logLevel #2277

Closed
seanyu4296 opened this issue Jun 13, 2021 · 10 comments
Closed

doc: Getting started typescript still uses logLevel #2277

seanyu4296 opened this issue Jun 13, 2021 · 10 comments
Labels
bug Something isn't working stale

Comments

@seanyu4296
Copy link

Examples are not updated

This one still exposes logLevel but that isn't available afaik https://github.com/open-telemetry/opentelemetry-js/blob/main/getting-started/ts-example/README.md

Correct me if i am wrong

@seanyu4296 seanyu4296 added the bug Something isn't working label Jun 13, 2021
@dyladan
Copy link
Member

dyladan commented Jun 16, 2021

The getting started guide is woefully out of date

@svrnm
Copy link
Member

svrnm commented Jun 23, 2021

Would it make sense to review the existing docs, throw away what's not relevant any more and move everything into the "official docs" on the homepage (see #1683 as well). I can help with that.

@ritwizsinha
Copy link

Hello, I am new to opentelemetry and was trying it out locally when I encountered this issue firsthand. I was looking for making some contribution to OpenTelemetry and would love to start with this. I would like to work on this issue, if someone could just direct me to the relevant sources

@dyladan
Copy link
Member

dyladan commented Jul 6, 2021

Where did you see the getting started docs? This should be fixed

@svrnm
Copy link
Member

svrnm commented Jul 6, 2021

@ritwizsinha have a look here: https://github.com/open-telemetry/opentelemetry-js/blob/main/getting-started/README.md

Best you make fork, clone the repo locally and edit the README.md while going through the tutorial.

@dyladan
Copy link
Member

dyladan commented Jul 6, 2021

Ahh the website changes aren't merged yet. open-telemetry/opentelemetry.io#621

You can see the updated version here: https://github.com/open-telemetry/opentelemetry-js/blob/main/website_docs/getting_started/nodejs.md

@ritwizsinha
Copy link

Okay Thank you

@svrnm
Copy link
Member

svrnm commented Jul 6, 2021

Ah, I was confused from the last time if and how we keep both (getting_started, website_docs) up until they are streamlined.

FYI, I just pushed: #2324 also in that context.

@github-actions
Copy link

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the stale label Jan 10, 2022
@github-actions
Copy link

github-actions bot commented Feb 7, 2022

This issue was closed because it has been stale for 14 days with no activity.

@github-actions github-actions bot closed this as completed Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working stale
Projects
None yet
Development

No branches or pull requests

4 participants