Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Express.js example missing #2391

Closed
ghost opened this issue Aug 3, 2021 · 4 comments · Fixed by #2437
Closed

Express.js example missing #2391

ghost opened this issue Aug 3, 2021 · 4 comments · Fixed by #2437
Assignees
Labels
document Documentation-related

Comments

@ghost
Copy link

ghost commented Aug 3, 2021

The examples README.md points to a non-existing express.js example: https://github.com/open-telemetry/opentelemetry-js/blame/main/examples/README.md#L19

Considering that Express.js is the most widely used Node.js web application framework, I feel like that example should definitely be present.

Cheers :)

@ghost ghost added the instrumentation label Aug 3, 2021
@dyladan
Copy link
Member

dyladan commented Aug 3, 2021

It was moved to the contrib repo https://github.com/open-telemetry/opentelemetry-js-contrib/tree/main/examples/express

The examples readme should be updated to remove it and to point to the contrib repo for additional examples.

@vmarchaud vmarchaud added document Documentation-related and removed instrumentation labels Aug 7, 2021
@banothurameshnaik
Copy link
Contributor

@dyladan
Can I correct this link? and raise a PR?(If allowed, you can assign to me).

@dyladan
Copy link
Member

dyladan commented Aug 27, 2021

Yes please

@banothurameshnaik
Copy link
Contributor

Here is the PR with changes #2437, Please have a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
document Documentation-related
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants