Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decode values from OTEL_RESOURCE_ATTRIBUTES #3131

Closed
lgfa29 opened this issue Jul 31, 2022 · 2 comments · Fixed by #3341
Closed

Decode values from OTEL_RESOURCE_ATTRIBUTES #3131

lgfa29 opened this issue Jul 31, 2022 · 2 comments · Fixed by #3341
Labels
feature-request

Comments

@lgfa29
Copy link

lgfa29 commented Jul 31, 2022

While using the Go SDK I noticed an inconsistency in how OTEL_RESOURCE_ATTRIBUTES baggage values are encoded and decoded. This was due to a difference in the version of the W3C Baggage spec used for baggage propagation and the OTEL_RESOURCE_ATTRIBUTES decoding.

open-telemetry/opentelemetry-specification#2670 updates the W3C Baggage spec version used by the Resource spec to require percent-decoding values from OTEL_RESOURCE_ATTRIBUTES.
@github-actions
Copy link

github-actions bot commented Oct 3, 2022

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the stale label Oct 3, 2022
@github-actions
Copy link

This issue was closed because it has been stale for 14 days with no activity.

@legendecas legendecas reopened this Oct 18, 2022
@legendecas legendecas mentioned this issue Oct 18, 2022
Merged
6 tasks
@github-actions github-actions bot removed the stale label Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(resources): strict OTEL_RESOURCE_ATTRIBUTES decoding legendecas/opentelemetry-js
2 participants
@lgfa29 @legendecas