Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure OTLP metrics exporter with environment variables #3193

Open
legendecas opened this issue Aug 24, 2022 · 6 comments
Open

Configure OTLP metrics exporter with environment variables #3193

legendecas opened this issue Aug 24, 2022 · 6 comments
Labels
feature-request never-stale signal:metrics Issues and PRs related to general metrics signal

Comments

@legendecas
Copy link
Member

https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/sdk_exporters/otlp.md

OTLP exporter spec defines that the OTLP exporter should be automatically configured with a PeriodicMetricReader when using OTEL_METRICS_EXPORTER. Their aggregation and temporality preferences should also be configured with OTEL_EXPORTER_OTLP_METRICS_TEMPORALITY_PREFERENCE and OTEL_EXPORTER_OTLP_METRICS_DEFAULT_HISTOGRAM_AGGREGATION.

@dyladan
Copy link
Member

dyladan commented Aug 31, 2022

I saw you added this to the metrics GA milestone. Do you believe this is blocking the metrics SDK?

@legendecas
Copy link
Member Author

No, I believe it's not blocking but rather good to have.

@dyladan dyladan modified the milestones: Metrics GA, Metrics After GA Aug 31, 2022
@legendecas legendecas added the signal:metrics Issues and PRs related to general metrics signal label Sep 2, 2022
@pichlermarc
Copy link
Member

Just went through the code and saw that the following env-vars from this spec are also not implemented right now:

  • OTEL_EXPORTER_OTLP_METRICS_COMPRESSION (currently the trace setting is used instead)
  • OTEL_EXPORTER_OTLP_METRICS_INSECURE (currently the trace setting is used instead)
  • OTEL_EXPORTER_OTLP_METRICS_CERTIFICATE (currently the trace setting is used instead)
  • OTEL_EXPORTER_OTLP_METRICS_CLIENT_KEY (currently the trace setting is used instead)
  • OTEL_EXPORTER_OTLP_METRICS_CLIENT_CERTIFICATE (currently the trace setting is used instead)

@github-actions
Copy link

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@pichlermarc
Copy link
Member

Not stale as we'd need to implement OTEL_EXPORTER_OTLP_METRICS_DEFAULT_HISTOGRAM_AGGREGATION after #3506 lands. 🙂
(we also need to address the comment I made earlier)

@pichlermarc
Copy link
Member

When this is done, we'll also need to update the spec compliance matrix with the newly supported env vars.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request never-stale signal:metrics Issues and PRs related to general metrics signal
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants