Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sdk-node] implement enviornment configuration for auto-paired PeriodicExportingMetricReader #4655

Open
2 tasks
pichlermarc opened this issue Apr 23, 2024 · 1 comment
Labels
needs:refinement This issue needs to be refined/broken apart into sub-issues before implementation pkg:sdk-node spec-feature This is a request to implement a new feature which is already specified by the OTel specification type:feature A feature with no sub-issues to address

Comments

@pichlermarc
Copy link
Member

Description

The specification defines that PeriodicExporingMetricReaders that are auto-paired with an exporter can be configured via environment variables.

For this issue to be considered done we need to:

Additional infomation

Original feature-request:

@pichlermarc pichlermarc added spec-feature This is a request to implement a new feature which is already specified by the OTel specification pkg:sdk-node type:feature A feature with no sub-issues to address labels Apr 23, 2024
@pichlermarc pichlermarc changed the title [sdk-node] implement enviornment configuration for auto-paired MetricReader [sdk-node] implement enviornment configuration for auto-paired PeriodicExportingMetricReader Apr 23, 2024
@aabmass
Copy link
Member

aabmass commented Apr 23, 2024

The specification defines that PeriodicExporingMetricReaders that are auto-paired with an exporter can be configured via environment variables.

Does the spec actually say anything about this only applying when auto-paired? The BatchSpanProcessor reads from the environment variables directly

this._maxExportBatchSize =
typeof config?.maxExportBatchSize === 'number'
? config.maxExportBatchSize
: env.OTEL_BSP_MAX_EXPORT_BATCH_SIZE;

so the environment variables are applied globally. I'm guessing this is related to the yaml config file conversation and the related concern around precedence

@pichlermarc pichlermarc added the needs:refinement This issue needs to be refined/broken apart into sub-issues before implementation label Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs:refinement This issue needs to be refined/broken apart into sub-issues before implementation pkg:sdk-node spec-feature This is a request to implement a new feature which is already specified by the OTel specification type:feature A feature with no sub-issues to address
Projects
None yet
Development

No branches or pull requests

2 participants