Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[spec] Remove gauge, add observer #739

Closed
dyladan opened this issue Jan 29, 2020 · 3 comments · Fixed by #828
Closed

[spec] Remove gauge, add observer #739

dyladan opened this issue Jan 29, 2020 · 3 comments · Fixed by #828
Assignees
@obecny
Labels
feature-request
Milestone
Beta

Comments

@dyladan
Copy link
Member

dyladan commented Jan 29, 2020 •
edited by mayurkale22

OTEP: open-telemetry/oteps#80
SPEC: open-telemetry/opentelemetry-specification#430 (https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/api-metrics.md#observer)

Wait on #738 to merge before working on this issue.
@dyladan dyladan added feature-request Dependency on other PR This PR can't be merged because it has dependency on other PRs nonconforming waiting-for-spec and removed nonconforming labels Jan 29, 2020
@mayurkale22 mayurkale22 added up-for-grabs Good for taking. Extra help will be provided by maintainers and removed waiting-for-spec labels Feb 18, 2020
@mayurkale22 mayurkale22 added this to the Beta milestone Feb 18, 2020
@mayurkale22 mayurkale22 removed the Dependency on other PR This PR can't be merged because it has dependency on other PRs label Feb 18, 2020
@mayurkale22 mayurkale22 mentioned this issue Feb 18, 2020
Merged
@dyladan dyladan mentioned this issue Feb 19, 2020
Closed
46 tasks
@mayurkale22 mayurkale22 removed the up-for-grabs Good for taking. Extra help will be provided by maintainers label Feb 21, 2020
@obecny obecny mentioned this issue Mar 2, 2020
Merged
@RichardWright
Copy link

Can I ask why this was removed? If I normally use a gauge elsewhere, what metric should I be using with open telemetry? I'm quite unsure.

@gvelez17
Copy link

Same question here - I am finding myself using a histogram where I just want a gauge, and then going thru gyrations to get the observed number back - it would be simpler to just use a gauge

@legendecas
Copy link
Member

Please follow open-telemetry/opentelemetry-specification#2318 for spec feature request of synchronous gauge.

pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this issue Dec 15, 2023
@seemk
chore(pino): get rid of TODO (open-telemetry#739)
29e4ab0 
* refactor: pino instrumentation: remove unnecessary _isEnabled

* fix: linting issues

* fix: lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@obecny obecny

Labels
feature-request
Projects
None yet
Milestone
Beta
Development

Successfully merging a pull request may close this issue.

feat: metric observer obecny/opentelemetry-js
6 participants
@gvelez17 @RichardWright @obecny @dyladan @mayurkale22 @legendecas