Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module opentelemetry/instrumentation-grpc required #2283

Merged
merged 3 commits into from Jun 21, 2021

Conversation

pramodsreek
Copy link
Contributor

This is a minor README.md update. It looks like we also need module @opentelemetry/instrumentation-grpc, otherwise we are getting module not found error.
% node -r ./tracing.js app.js
internal/modules/cjs/loader.js:888
throw err;
^

Error: Cannot find module '@opentelemetry/instrumentation-grpc'
Require stack:

  • /tracing.js
  • internal/preload
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:885:15)
    at Function.Module._load (internal/modules/cjs/loader.js:730:27)
    at Module.require (internal/modules/cjs/loader.js:957:19)
    at require (internal/modules/cjs/helpers.js:88:18)
    at Object. (/tracing.js:7:33)
    at Module._compile (internal/modules/cjs/loader.js:1068:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1097:10)
    at Module.load (internal/modules/cjs/loader.js:933:32)
    at Function.Module._load (internal/modules/cjs/loader.js:774:14)
    at Module.require (internal/modules/cjs/loader.js:957:19) {
    code: 'MODULE_NOT_FOUND',
    requireStack: [ '/tracing.js', 'internal/preload' ]
    }

Which problem is this PR solving?

  • If we follow the README.md to try opentelemetry sample, we are getting a module not found error. We had to install @opentelemetry/instrumentation-grpc to resolve this issue.

Short description of the changes

  • Added module @opentelemetry/instrumentation-grpc in npm install.

This is a minor README.md update. It looks like we also need module @opentelemetry/instrumentation-grpc, otherwise we are getting module not found error.
% node -r ./tracing.js app.js
internal/modules/cjs/loader.js:888
  throw err;
  ^

Error: Cannot find module '@opentelemetry/instrumentation-grpc'
Require stack:
- /tracing.js
- internal/preload
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:885:15)
    at Function.Module._load (internal/modules/cjs/loader.js:730:27)
    at Module.require (internal/modules/cjs/loader.js:957:19)
    at require (internal/modules/cjs/helpers.js:88:18)
    at Object.<anonymous> (/Users/ps105769/POC/open_tel/tracing.js:7:33)
    at Module._compile (internal/modules/cjs/loader.js:1068:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1097:10)
    at Module.load (internal/modules/cjs/loader.js:933:32)
    at Function.Module._load (internal/modules/cjs/loader.js:774:14)
    at Module.require (internal/modules/cjs/loader.js:957:19) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [ '/tracing.js', 'internal/preload' ]
}
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jun 15, 2021

CLA Signed

The committers are authorized under a signed CLA.

@dyladan dyladan added the document Documentation-related label Jun 16, 2021
@codecov
Copy link

codecov bot commented Jun 16, 2021

Codecov Report

Merging #2283 (bbdd662) into main (7860344) will increase coverage by 0.01%.
The diff coverage is n/a.

❗ Current head bbdd662 differs from pull request most recent head 541e3f1. Consider uploading reports for the commit 541e3f1 to get more accurate results

@@            Coverage Diff             @@
##             main    #2283      +/-   ##
==========================================
+ Coverage   92.68%   92.70%   +0.01%     
==========================================
  Files         145      145              
  Lines        5184     5184              
  Branches     1060     1060              
==========================================
+ Hits         4805     4806       +1     
+ Misses        379      378       -1     
Impacted Files Coverage Δ
...emetry-api-metrics/src/platform/node/globalThis.ts 100.00% <0.00%> (+100.00%) ⬆️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
document Documentation-related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants