From 077ba2fac0562449c5f15c3b831b96f79a34e84f Mon Sep 17 00:00:00 2001 From: Daniel Dyla Date: Fri, 25 Jun 2021 18:05:16 -0400 Subject: [PATCH 1/2] chore: use setup-node --- .github/workflows/unit-test.yml | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/.github/workflows/unit-test.yml b/.github/workflows/unit-test.yml index 5c9b3f0faa..a44b595149 100644 --- a/.github/workflows/unit-test.yml +++ b/.github/workflows/unit-test.yml @@ -10,16 +10,18 @@ jobs: strategy: fail-fast: false matrix: - container: ["node:8", "node:10", "node:12", "node:14", "node:16"] + node_version: ["8", "10", "12", "14", "16"] runs-on: ubuntu-latest - container: - image: ${{ matrix.container }} env: NPM_CONFIG_UNSAFE_PERM: true steps: - name: Checkout uses: actions/checkout@v1 + - uses: actions/setup-node@v2 + with: + node-version: ${{ matrix.node_version }} + - name: restore lock files uses: actions/cache@master # must use unreleased master to cache multiple paths id: cache @@ -33,7 +35,7 @@ jobs: metapackages/*/package-lock.json packages/*/package-lock.json integration-tests/*/package-lock.json - key: ${{ runner.os }}-unit_test-${{ matrix.container }}-${{ hashFiles('**/package.json') }} + key: ${{ runner.os }}-unit_test-${{ matrix.node_version }}-${{ hashFiles('**/package.json') }} - name: Install and Build (cache miss) 🔧 if: steps.cache.outputs.cache-hit != 'true' run: | @@ -53,7 +55,7 @@ jobs: run: npm run test - name: Report Coverage run: npm run codecov - if: ${{ matrix.container == 'node:14' }} + if: ${{ matrix.node_version == '14' }} browser-tests: runs-on: ubuntu-latest container: From 59b6632b7015fadcf15c8c4fcfb24816b49d2d74 Mon Sep 17 00:00:00 2001 From: Daniel Dyla Date: Fri, 25 Jun 2021 18:11:42 -0400 Subject: [PATCH 2/2] chore: remove previous chown --- .github/workflows/unit-test.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/unit-test.yml b/.github/workflows/unit-test.yml index a44b595149..3bd874bed0 100644 --- a/.github/workflows/unit-test.yml +++ b/.github/workflows/unit-test.yml @@ -40,7 +40,6 @@ jobs: if: steps.cache.outputs.cache-hit != 'true' run: | npm install --ignore-scripts - chown -R 1001:121 "/github/home/.npm" # fix npm cache permissions for npm v7 npx lerna bootstrap --no-ci npm run compile