Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add includePrerelease option to instrumentation config #2309

Merged
merged 5 commits into from Jul 17, 2021

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented Jun 30, 2021

Fixes #2294

@codecov
Copy link

codecov bot commented Jun 30, 2021

Codecov Report

Merging #2309 (dabdf19) into main (90e941a) will not change coverage.
The diff coverage is 20.00%.

@@           Coverage Diff           @@
##             main    #2309   +/-   ##
=======================================
  Coverage   92.75%   92.75%           
=======================================
  Files         145      145           
  Lines        5216     5216           
  Branches     1068     1068           
=======================================
  Hits         4838     4838           
  Misses        378      378           
Impacted Files Coverage Δ
...strumentation/src/platform/node/instrumentation.ts 23.61% <20.00%> (ø)

Copy link
Member

@Flarna Flarna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. I wonder why browser doesn't need something like this.

A test would be nice.

@dyladan
Copy link
Member Author

dyladan commented Jun 30, 2021

Looks fine. I wonder why browser doesn't need something like this.

A test would be nice.

Browser doesn't do the version checking. I'll see if i can add a test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to instrument prerelease tagged packages
6 participants