Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix tracer-web example webpack config #2326

Merged
merged 1 commit into from Jul 6, 2021

Conversation

jonchurch
Copy link
Contributor

Which problem is this PR solving?

Short description of the changes

  • Removed offending line from webpack config

Copy link
Member

@dyladan dyladan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the line in question was added by @obecny ac81e17#diff-2337895425ca89703bc0c2d23649b18aefb5fd5259db29452dcedac8d3625f0bR11

Looks good to me but I want his approval before this merges in case we're missing something.

@codecov
Copy link

codecov bot commented Jul 6, 2021

Codecov Report

Merging #2326 (88ecb4b) into main (6ed8d92) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2326   +/-   ##
=======================================
  Coverage   92.77%   92.77%           
=======================================
  Files         145      145           
  Lines        5216     5216           
  Branches     1068     1068           
=======================================
  Hits         4839     4839           
  Misses        377      377           

@jonchurch
Copy link
Contributor Author

@dyladan Sounds good to me, I spent maybe 10 mins trying to understand it so by no means do I think I got to the root of it.

@jonchurch
Copy link
Contributor Author

Interestingly, it was a .ts file that it was trying to bundle, and there aren't any other typescript files in the examples. Yet, the webpack config does have .ts rigging in it.

@dyladan
Copy link
Member

dyladan commented Jul 6, 2021

Interestingly, it was a .ts file that it was trying to bundle, and there aren't any other typescript files in the examples. Yet, the webpack config does have .ts rigging in it.

it was probably copied or modified from one of the other packages

Copy link
Member

@obecny obecny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it was file I was using for testing some changes temporary, can be removed, thx

@dyladan dyladan added the document Documentation-related label Jul 6, 2021
@dyladan dyladan merged commit 3a327dd into open-telemetry:main Jul 6, 2021
@jonchurch jonchurch deleted the 2325-tracer-web-webpack branch July 6, 2021 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
document Documentation-related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tracer-Web example npm start fails
3 participants