Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix Lint warnings in api-metrics and context-zone-peer-dep #2390

Merged
merged 5 commits into from Aug 6, 2021

Conversation

alisabzevari
Copy link
Contributor

@alisabzevari alisabzevari commented Aug 3, 2021

related to #1093,

Which problem is this PR solving?

  • This PR fixes lint warnings in api-metrics and context-zone-peer-dep packages.

Short description of the changes

  • Fix lint warnings

@codecov
Copy link

codecov bot commented Aug 3, 2021

Codecov Report

Merging #2390 (e3a8408) into main (b69ff35) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #2390   +/-   ##
=======================================
  Coverage   92.78%   92.78%           
=======================================
  Files         145      145           
  Lines        5226     5226           
  Branches     1071     1071           
=======================================
  Hits         4849     4849           
  Misses        377      377           
Impacted Files Coverage Δ
...ackages/opentelemetry-api-metrics/src/NoopMeter.ts 82.35% <100.00%> (ø)
...kages/opentelemetry-api-metrics/src/api/metrics.ts 90.90% <100.00%> (ø)
...ry-context-zone-peer-dep/src/ZoneContextManager.ts 85.18% <100.00%> (ø)

@alisabzevari
Copy link
Contributor Author

I removed the last commit because I realized someone else created a PR for that.

@alisabzevari alisabzevari changed the title Fix Lint warnings in api-metrics, context-zone-peer-dep, and context-async-hooks Fix Lint warnings in api-metrics and context-zone-peer-dep Aug 3, 2021
Co-authored-by: Daniel Dyla <dyladan@users.noreply.github.com>
@dyladan dyladan changed the title Fix Lint warnings in api-metrics and context-zone-peer-dep chore: fix Lint warnings in api-metrics and context-zone-peer-dep Aug 4, 2021
Copy link
Member

@obecny obecny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice !

@dyladan dyladan requested a review from a team as a code owner August 6, 2021 13:26
@dyladan dyladan merged commit 08828b4 into open-telemetry:main Aug 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants