chore: Fix lint warnings in core package #2405
Conversation
alisabzevari
changed the title
Codecov Report
@@ Coverage Diff @@
## main #2405 +/- ##
==========================================
- Coverage 92.64% 92.64% -0.01%
==========================================
Files 137 137
Lines 4974 4973 -1
Branches 1047 1047
==========================================
- Hits 4608 4607 -1
Misses 366 366
|
alisabzevari
force-pushed
the
lint-warnings-core
branch
from
4ba6502
to
8fe9f66
Compare
No, I just saw using |
| @@ -129,6 +130,7 @@ export function hrTimeToTimeStamp(hrTime: api.HrTime): string { | |||
| * Convert hrTime to nanoseconds. | |||
| * @param hrTime | |||
| */ | |||
| // eslint-disable-next-line @typescript-eslint/no-shadow | |||
There was a problem hiding this comment.
I think the no-shadow error should be rather fixed then ignored, in most cases this should be an easy fix
There was a problem hiding this comment.
I have answered this in another comment as well. I couldn't find a better name for the parameter and thought the name of the parameter should be meaningful for users who don't use types.
There was a problem hiding this comment.
I would be fine with just using time
There was a problem hiding this comment.
The parameter name is only ever likely to show up in intellisense and generated docs. In both cases it woudl be alongside its type which is clearly named.
dyladan
changed the title
|
I updated the PR title. Please in the future use conventional commits for titles since they become the commit message when PRs are squashed. |
related to #1093,
Which problem is this PR solving?
corepackage.Short description of the changes