fix!: remove 'Http' from W3C propagator names #2429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aabmass
force-pushed
the
rename-tracecontext-2428
branch
from
7d201d3
to
492107a
Compare
Codecov Report
@@ Coverage Diff @@
## main #2429 +/- ##
=======================================
Coverage 92.70% 92.70%
=======================================
Files 137 137
Lines 4993 4993
Branches 1056 1056
=======================================
Hits 4629 4629
Misses 364 364
|
dyladan
approved these changes
Aug 26, 2021
Flarna
approved these changes
Aug 26, 2021
|
PTAL at #2428 (comment) and leave your thoughts. The baggage propagator also needs to be renamed and we need to decide on a name before merging this. |
vmarchaud
reviewed
Aug 29, 2021
aabmass
force-pushed
the
rename-tracecontext-2428
branch
from
c1b429a
to
280488c
Compare
aabmass
changed the title
- `HttpTraceContextPropagator` to `W3CTraceContextPropagator` - `HttpBaggagePropagator` to `W3CBaggagePropagator`
aabmass
force-pushed
the
rename-tracecontext-2428
branch
from
280488c
to
881703e
Compare
aabmass
force-pushed
the
rename-tracecontext-2428
branch
from
881703e
to
115134a
Compare
|
@vmarchaud thanks, I updated the README |
vmarchaud
approved these changes
Aug 30, 2021
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Fixes #2428
Short description of the changes
Renames:
HttpTraceContextPropagatortoW3CTraceContextPropagatorHttpBaggagePropagatortoW3CBaggagePropagatorThis is a breaking change
Fix in the contrib repo: open-telemetry/opentelemetry-js-contrib#644. I didn't find any places that need updating in
opentelemetrry-js-apioropentelemetry.iorepos.