feat(opentelemetry-sdk-trace-base): implemented general limits of attributes #2430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ributes Signed-off-by: Banothu Ramesh Naik <rameshnaik5521@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #2430 +/- ##
==========================================
- Coverage 93.22% 93.21% -0.01%
==========================================
Files 137 137
Lines 5002 5014 +12
Branches 1057 1060 +3
==========================================
+ Hits 4663 4674 +11
- Misses 339 340 +1
|
obecny
reviewed
Aug 26, 2021
|
Can someone review this PR? |
rauno56
approved these changes
Sep 6, 2021
|
It looks like merging broke the this PR. Please take a look. |
|
I will check broken changes, thanks |
Signed-off-by: Banothu Ramesh Naik <rameshnaik5521@gmail.com>
|
@rauno56 I fixed the broken changes. |
dyladan
approved these changes
Sep 8, 2021
dyladan
reviewed
Sep 8, 2021
| @@ -212,6 +214,11 @@ export class Tracer implements api.Tracer { | |||
| return api.context.with(contextWithSpanSet, fn, undefined, span); | |||
| } | |||
|
|
|||
| /** Returns the active {@link GeneralLimits}. */ | |||
| getGeneralLimits(): GeneralLimits { | |||
There was a problem hiding this comment.
Why do we have this function? It is not part of the interface. If it is just for testing, you can access the private field by doing tracer["_generalLimits"] in the test.
There was a problem hiding this comment.
We can access the way you mentioned.
I just followed the pattern we already have like getSpanLimits(): SpanLimits { in line 223
obecny
approved these changes
Sep 8, 2021
Merged
This was referenced May 26, 2023
[Snyk] Upgrade @opentelemetry/exporter-jaeger from 0.25.0 to 0.26.0
0xETHengineer/opentelemetry-js#2
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes
OTEL_ATTRIBUTE_VALUE_LENGTH_LIMITandOTEL_ATTRIBUTE_COUNT_LIMITattributes as general tracer attributes.