Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: simplify unit test cache #2435

Merged
merged 2 commits into from Aug 30, 2021
Merged

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented Aug 27, 2021

Now that we are hoisting modules, the caching step is significantly more efficient than it used to be. Combined with the latest version of the caching action supporting multiple paths properly, this drastically simplifies the caching part of our action and speeds up the tests.

Cache Hit

~2-3 minutes

image

Cache Miss

~3-4 minutes

image

@codecov
Copy link

codecov bot commented Aug 27, 2021

Codecov Report

Merging #2435 (16c8900) into main (dbfabd2) will decrease coverage by 0.02%.
The diff coverage is n/a.

❗ Current head 16c8900 differs from pull request most recent head bb76be1. Consider uploading reports for the commit bb76be1 to get more accurate results

@@            Coverage Diff             @@
##             main    #2435      +/-   ##
==========================================
- Coverage   92.70%   92.68%   -0.03%     
==========================================
  Files         137      137              
  Lines        4993     4993              
  Branches     1056     1056              
==========================================
- Hits         4629     4628       -1     
- Misses        364      365       +1     
Impacted Files Coverage Δ
...emetry-api-metrics/src/platform/node/globalThis.ts 0.00% <0.00%> (-100.00%) ⬇️

@dyladan dyladan marked this pull request as ready for review August 27, 2021 15:30
@dyladan dyladan requested a review from a team as a code owner August 27, 2021 15:30
@vmarchaud vmarchaud merged commit facd8c0 into open-telemetry:main Aug 30, 2021
@dyladan dyladan deleted the simple-cache branch August 30, 2021 12:30
@dyladan dyladan mentioned this pull request Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants