Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(exporter): fix lint warnings #2447

Merged
merged 3 commits into from Sep 3, 2021

Conversation

alisabzevari
Copy link
Contributor

related to #1093

Which problem is this PR solving?

  • This PR fixes lint warnings in exporter-prometheus and exporter-zipkin packages.

Short description of the changes

  • Fix lint warnings
  • The warnings regarding the deprecation of url.parse haven't been fixed because they need more manual work. I will tackle them in a different PR if needed.
  • I have renamed statusCodeTagName and statusDescriptionTagName exported variables to fix the name shadowing issue in transform.ts, but I am not sure this doesn't have any side effects. Let me know if I should revert them.

@alisabzevari alisabzevari requested a review from a team as a code owner September 2, 2021 18:45
@codecov
Copy link

codecov bot commented Sep 2, 2021

Codecov Report

Merging #2447 (bd68272) into main (dc574f7) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #2447   +/-   ##
=======================================
  Coverage   92.56%   92.56%           
=======================================
  Files         134      134           
  Lines        4871     4871           
  Branches     1036     1036           
=======================================
  Hits         4509     4509           
  Misses        362      362           
Impacted Files Coverage Δ
...ackages/opentelemetry-exporter-zipkin/src/types.ts 100.00% <ø> (ø)
...etry-exporter-prometheus/src/PrometheusExporter.ts 90.66% <100.00%> (ø)
...exporter-prometheus/src/PrometheusLabelsBatcher.ts 100.00% <100.00%> (ø)
...elemetry-exporter-zipkin/src/platform/node/util.ts 96.66% <100.00%> (ø)
...ges/opentelemetry-exporter-zipkin/src/transform.ts 100.00% <100.00%> (ø)
...ckages/opentelemetry-exporter-zipkin/src/zipkin.ts 100.00% <100.00%> (ø)
...ackages/opentelemetry-shim-opentracing/src/shim.ts 94.25% <100.00%> (ø)

Copy link
Member

@obecny obecny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@obecny obecny added the internal label Sep 3, 2021
@obecny obecny merged commit f810779 into open-telemetry:main Sep 3, 2021
@dyladan dyladan mentioned this pull request Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants