Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(instrumentation-fetch): fix lint warnings #2454

Conversation

alisabzevari
Copy link
Contributor

related to #1093

Which problem is this PR solving?

  • This PR fixes lint warnings in instrumentation-fetch package.

Short description of the changes

  • Fix lint warnings.

@alisabzevari alisabzevari requested a review from a team as a code owner September 3, 2021 14:39
@codecov
Copy link

codecov bot commented Sep 3, 2021

Codecov Report

Merging #2454 (2d3727b) into main (6617573) will decrease coverage by 0.14%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##             main    #2454      +/-   ##
==========================================
- Coverage   92.73%   92.58%   -0.15%     
==========================================
  Files         137      134       -3     
  Lines        4996     4871     -125     
  Branches     1057     1036      -21     
==========================================
- Hits         4633     4510     -123     
+ Misses        363      361       -2     
Impacted Files Coverage Δ
...s/opentelemetry-instrumentation-fetch/src/fetch.ts 96.96% <66.66%> (ø)
...sync-hooks/src/AbstractAsyncHooksContextManager.ts
...async-hooks/src/AsyncLocalStorageContextManager.ts
...ontext-async-hooks/src/AsyncHooksContextManager.ts

Copy link
Member

@obecny obecny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants