Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(instrumentation-http): fix lint warnings #2455

Merged

Conversation

alisabzevari
Copy link
Contributor

related to #1093

Which problem is this PR solving?

  • This PR fixes lint warnings in instrumentation-http package.

Short description of the changes

  • Fix lint warnings

@alisabzevari alisabzevari requested a review from a team as a code owner September 3, 2021 15:24
@codecov
Copy link

codecov bot commented Sep 3, 2021

Codecov Report

Merging #2455 (ab99c8f) into main (7dc2538) will increase coverage by 0.48%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2455      +/-   ##
==========================================
+ Coverage   92.22%   92.71%   +0.48%     
==========================================
  Files         120      137      +17     
  Lines        4013     4996     +983     
  Branches      850     1057     +207     
==========================================
+ Hits         3701     4632     +931     
- Misses        312      364      +52     
Impacted Files Coverage Δ
...ges/opentelemetry-instrumentation-http/src/http.ts 94.98% <100.00%> (ø)
...es/opentelemetry-instrumentation-http/src/utils.ts 99.02% <100.00%> (ø)
...ry-context-zone-peer-dep/src/ZoneContextManager.ts 85.18% <0.00%> (ø)
...kages/opentelemetry-exporter-collector/src/util.ts 100.00% <0.00%> (ø)
...-instrumentation-fetch/src/enums/AttributeNames.ts 100.00% <0.00%> (ø)
packages/opentelemetry-sdk-trace-web/src/utils.ts 94.90% <0.00%> (ø)
...s/opentelemetry-instrumentation-fetch/src/fetch.ts 96.96% <0.00%> (ø)
...es/opentelemetry-context-zone-peer-dep/src/util.ts 100.00% <0.00%> (ø)
...ation-xml-http-request/src/enums/AttributeNames.ts 100.00% <0.00%> (ø)
.../opentelemetry-exporter-collector/src/transform.ts 88.69% <0.00%> (ø)
... and 9 more

Copy link
Member

@obecny obecny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants