You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
If Config.Validate() of a component returns false, the collector lambda layer cannot start in AWS lambda. As a result, the user lambda function is broken.
Describe the solution you'd like
Depending on the component, an invalid component configuration may not need to fail the whole collector lambda layer. We could let that component run in no-op.
Describe alternatives you've considered
Tried removing all config validation logic in the component and moved them to Start function. If config is invalid, just print a message instead. However, opentelemetry-collector-contrib code reviewer would like to check if there is other way to go.
Is your feature request related to a problem? Please describe.
If
Config.Validate()
of a component returns false, the collector lambda layer cannot start in AWS lambda. As a result, the user lambda function is broken.Describe the solution you'd like
Depending on the component, an invalid component configuration may not need to fail the whole collector lambda layer. We could let that component run in
no-op
.Describe alternatives you've considered
Tried removing all config validation logic in the component and moved them to
Start
function. If config is invalid, just print a message instead. However, opentelemetry-collector-contrib code reviewer would like to check if there is other way to go.Additional context
PR review comment
The component PR
The text was updated successfully, but these errors were encountered: