Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Add no-op support for collector lambda layer #1181

Open
jerrytfleung opened this issue Mar 6, 2024 · 0 comments
Open

Feature request: Add no-op support for collector lambda layer #1181

jerrytfleung opened this issue Mar 6, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@jerrytfleung
Copy link

Is your feature request related to a problem? Please describe.
If Config.Validate() of a component returns false, the collector lambda layer cannot start in AWS lambda. As a result, the user lambda function is broken.

Describe the solution you'd like
Depending on the component, an invalid component configuration may not need to fail the whole collector lambda layer. We could let that component run in no-op.

Describe alternatives you've considered
Tried removing all config validation logic in the component and moved them to Start function. If config is invalid, just print a message instead. However, opentelemetry-collector-contrib code reviewer would like to check if there is other way to go.

Additional context
PR review comment
The component PR

@jerrytfleung jerrytfleung added the enhancement New feature or request label Mar 6, 2024
@jerrytfleung jerrytfleung changed the title Add no-op support for collector lambda layer Feature request: Add no-op support for collector lambda layer Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant