Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node.js lambda layer - instrumentation error #159

Closed
ghost opened this issue Oct 21, 2021 · 6 comments
Closed

Node.js lambda layer - instrumentation error #159

ghost opened this issue Oct 21, 2021 · 6 comments

Comments

@ghost
Copy link

ghost commented Oct 21, 2021

Steps to reproduce:

  • build and deploy layer
  • create sample JS lambda
  • add layer
  • configure AWS_LAMBDA_EXEC_WRAPPER
    Result: Uncaught Exception {"errorType":"Runtime.ImportModuleError(...)

The problem was fixed by open-telemetry/opentelemetry-js#2450 which was released with "@opentelemetry/instrumentation": "0.26.0". I manually changed the dependency and it works.

Propsed solution:

@anuraaga who could help with that? Especially releasing opentelemetry-instrumentation-aws-lambda - I'm green in this respect.

@anuraaga
Copy link
Contributor

@kubawach Do we need a new release for opentelemetry-instrumentation-aws-lambda? It seems the currently released 0.26.0 does target 0.26.0 of opentelemetry/instrumentation, doesn't it?

https://github.com/open-telemetry/opentelemetry-js-contrib/blob/main/plugins/node/opentelemetry-instrumentation-aws-lambda/package.json#L64

@ghost
Copy link
Author

ghost commented Oct 22, 2021

@anuraaga unfortunately the latest released version of the opentelemetry-instrumentation-aws-lambda package is 0.26.0 which uses instrumentation 0.25.0 (see https://github.com/open-telemetry/opentelemetry-js-contrib/releases/tag/instrumentation-aws-lambda-v0.26.0).
The package.json from your link is main - once we release it we should be good

@anuraaga
Copy link
Contributor

I see - @willarmiros do you know the release process for that artifact? Do we generally release it ourselves when needed rather than waiting for the JS repo release?

@ghost ghost changed the title Node.js lamda layer - instrumentation error Node.js lambda layer - instrumentation error Oct 22, 2021
@willarmiros
Copy link
Contributor

We can release ourselves independent of the upstream JS schedule. We will plan a release in the near future and update this issue when it's out.

@ghost
Copy link
Author

ghost commented Oct 25, 2021

@willarmiros thanks, looking forward to :)

@ghost
Copy link
Author

ghost commented Nov 2, 2021

@ghost ghost closed this as completed Nov 2, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants