Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use k8s 1.28 native sidecar for OTEL collector sidecar mode #2376

Open
pavolloffay opened this issue Nov 20, 2023 · 2 comments · May be fixed by #2801
Open

Use k8s 1.28 native sidecar for OTEL collector sidecar mode #2376

pavolloffay opened this issue Nov 20, 2023 · 2 comments · May be fixed by #2801
Labels
area:collector Issues for deploying collector enhancement New feature or request help wanted Extra attention is needed

Comments

@pavolloffay
Copy link
Member

Component(s)

collector

Is your feature request related to a problem? Please describe.

The k8s 1.28 introduced "native sidecar" mode (init-container with restartPolicy: Always) https://kubernetes.io/blog/2023/08/25/native-sidecar-containers/.

The approach makes sure the sidecar starts/finishes before the application.

Describe the solution you'd like

Use the native sidecar for collector sidecar on k8s 1.28 and above.

Describe alternatives you've considered

No response

Additional context

No response
@pavolloffay pavolloffay added enhancement New feature or request needs triage area:collector Issues for deploying collector help wanted Extra attention is needed and removed needs triage labels Nov 20, 2023
@frzifus
Copy link
Member

frzifus commented Nov 23, 2023

I would like to give that a try.

@angelokurtis
Copy link
Contributor

Hey @frzifus, are you currently working on this task? If not, I'd be interested in contributing to it.

@frzifus frzifus linked a pull request Mar 29, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:collector Issues for deploying collector enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add featuregate for k8s 1.28 native sidecar container frzifus/opentelemetry-operator
3 participants
@angelokurtis @pavolloffay @frzifus