Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support the ability to override instrumentation image via annotation #2912

Open
BenB196 opened this issue Apr 29, 2024 · 1 comment
Open
Labels
area:auto-instrumentation Issues for auto-instrumentation enhancement New feature or request

Comments

@BenB196
Copy link

BenB196 commented Apr 29, 2024

Component(s)

No response

Is your feature request related to a problem? Please describe.

There are some cases, where you want to define a specific instrumentation image/version for a specific deployment, where needing to define a completely new Instrumentation CRD is a bit overkill. It would be nice to have the ability to define an override at the deployment/pod level for image/version.

Describe the solution you'd like

Support for defining an annotation that allows overriding image/version for a specific language:

Something like:

instrumentation.opentelemetry.io/inject-java-image: "ghcr.io/open-telemetry/opentelemetry-operator/autoinstrumentation-java:2.3.0"
instrumentation.opentelemetry.io/inject-dotnet-image: "ghcr.io/open-telemetry/opentelemetry-operator/autoinstrumentation-dotnet:1.1.0"

Describe alternatives you've considered

I could define multiple Instrumentation CRDs, however, when 95% of the file is the same and I just want to change 1 or 2 image versions for a specific deployment/pod, this is a bit overkill.

Additional context

I have some applications which need to run on some older instrumentation versions, but I'd like my "default" for applications to always target near the latest version.

@BenB196 BenB196 added enhancement New feature or request needs triage labels Apr 29, 2024
@pavolloffay pavolloffay added area:auto-instrumentation Issues for auto-instrumentation and removed needs triage labels Apr 30, 2024
@pavolloffay
Copy link
Member

I don't see much value in the proposal, given the use-case can be solved with the existing solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:auto-instrumentation Issues for auto-instrumentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants