Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[opentelemetry-php-instrumentation] PHP8.2 support registering hooks after a function was already executed #1307

Open
Nevay opened this issue May 8, 2024 · 1 comment

Comments

@Nevay
Copy link
Contributor

Nevay commented May 8, 2024

PHP ^8.2 allows manipulation of observers at runtime php/php-src#9062.

Should allow us to remove the limitation that hooks must be registered before a function is first executed. https://github.com/open-telemetry/opentelemetry-php-instrumentation?tab=readme-ov-file#caveats

Hooks must be registered before a function is first executed. You may encounter race conditions where the composer autoloader runs code that uses functions you wish to hook prior to the hooks being registered.

@brettmc
Copy link
Collaborator

brettmc commented May 9, 2024

ref: #1278
The feature is available in PHP from 8.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants