Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decode values from OTEL_RESOURCE_ATTRIBUTES #786

Closed
lgfa29 opened this issue Jul 31, 2022 · 3 comments · Fixed by #872
Closed

Decode values from OTEL_RESOURCE_ATTRIBUTES #786

lgfa29 opened this issue Jul 31, 2022 · 3 comments · Fixed by #872
Assignees
Labels
pinned Will not be removed by stalebot

Comments

@lgfa29
Copy link

lgfa29 commented Jul 31, 2022

While using the Go SDK I noticed an inconsistency in how OTEL_RESOURCE_ATTRIBUTES baggage values are encoded and decoded. This was due to a difference in the version of the W3C Baggage spec used for baggage propagation and the OTEL_RESOURCE_ATTRIBUTES decoding.

open-telemetry/opentelemetry-specification#2670 updates the W3C Baggage spec version used by the Resource spec to require percent-decoding values from OTEL_RESOURCE_ATTRIBUTES.

@sanketmehta28
Copy link
Member

sanketmehta28 commented Aug 10, 2022

Hi @bobstrecansky @brettmc @tidal: Can you please assign this to me?

@brettmc brettmc assigned brettmc and sanketmehta28 and unassigned brettmc Aug 10, 2022
@stale
Copy link

stale bot commented Sep 20, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale This issue didn't have recent activity label Sep 20, 2022
@stale
Copy link

stale bot commented Oct 1, 2022

This issue has been automatically closed because it has not had recent activity, but it can be reopened. Thank you for your contributions.

@stale stale bot closed this as completed Oct 1, 2022
@brettmc brettmc reopened this Oct 2, 2022
@stale stale bot removed the stale This issue didn't have recent activity label Oct 2, 2022
@brettmc brettmc added the pinned Will not be removed by stalebot label Oct 2, 2022
@brettmc brettmc added the help wanted This issue is looking for someone to work on it label Oct 25, 2022
@brettmc brettmc self-assigned this Nov 27, 2022
@brettmc brettmc removed the help wanted This issue is looking for someone to work on it label Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pinned Will not be removed by stalebot
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants