Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ExponentialHistogram data point to metrics SDK #2421

Closed
2 tasks done
codeboten opened this issue Jan 28, 2022 · 6 comments
Closed
2 tasks done

Add ExponentialHistogram data point to metrics SDK #2421

codeboten opened this issue Jan 28, 2022 · 6 comments
Assignees
Labels
metrics sdk Affects the SDK package.

Comments

@codeboten
Copy link
Contributor

codeboten commented Jan 28, 2022

The spec says there are 4 data points:

  1. Sum
  2. Gauge
  3. Histogram
  4. Exponential Histogram

Currently the SDK only implements 3 of them: Sum, Gauge, Histogram. See:
https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/datamodel.md#opentelemetry-protocol-data-model

@aabmass
Copy link
Member

aabmass commented Feb 1, 2022

You probably already know this Alex, but ExponentialHistogram aggregation is not in the Metrics SDK spec yet (open-telemetry/opentelemetry-specification#2252). I do think it's worth adding it to our export types now to get the OTLP exporter ready in anticipation 🙂

@aabmass aabmass added this to Unassigned SDK in Metrics RC Feb 1, 2022
@aabmass aabmass added the sdk Affects the SDK package. label Feb 1, 2022
@codeboten codeboten removed this from Unassigned SDK in Metrics RC Apr 8, 2022
@ocelotl ocelotl self-assigned this Aug 8, 2022
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Sep 12, 2022
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Sep 12, 2022
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Sep 12, 2022
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Sep 12, 2022
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Sep 12, 2022
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Sep 12, 2022
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Sep 12, 2022
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Sep 13, 2022
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Sep 14, 2022
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Sep 14, 2022
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Sep 14, 2022
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Sep 14, 2022
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Sep 15, 2022
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Sep 15, 2022
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Sep 16, 2022
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Sep 16, 2022
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Sep 16, 2022
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Sep 16, 2022
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Sep 16, 2022
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Sep 16, 2022
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Sep 16, 2022
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Sep 17, 2022
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Sep 17, 2022
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Sep 17, 2022
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Sep 17, 2022
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Sep 19, 2022
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Sep 19, 2022
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Sep 19, 2022
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Sep 19, 2022
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Sep 23, 2022
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Sep 27, 2022
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Oct 3, 2022
@clesleycode
Copy link

These are the major changes I'm thinking we'd need to make?:

  1. Implement an ExponentialHistogramAggregation class in aggregation.py.
  2. Add an ExponentialHistogram] data class to point.py
  3. Add support for that class in export/__init__.py.
  4. Modify any modules to make sure they support the new metric type.

I'm sure I'm missing small things here and there, but wanted to see if I'm on the right track before I go any further down a rabbit hole :)

@srikanthccv
Copy link
Member

@clesleycode The majority of work on this is done by @ocelotl. The last remaining part is implemented here #2964.

@clesleycode
Copy link

@srikanthccv should we close this then?

@srikanthccv
Copy link
Member

No, there is one more task pending. We should close this when that gets merged.

@ocelotl
Copy link
Contributor

ocelotl commented Jun 5, 2023

#2964 is merged, closing.

@ocelotl ocelotl closed this as completed Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
metrics sdk Affects the SDK package.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants