New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable ProcessResourceDetector by default #3916
Comments
@xrmx what are other languages doing by default? I looked at JS and it is not included with the default Resource. Can you check on Java and Go possibly? Another concern I had was the prevalence of forking in Python which would invalidate the |
For Go is not added by default but instrumentation is only manual AFAIK, for java the same but it's kinda suggested to add it per https://opentelemetry.io/docs/languages/java/resources/ For JS the auto instrumentation package enable it by default: https://github.com/open-telemetry/opentelemetry-js-contrib/tree/main/metapackages/auto-instrumentations-node/#usage-auto-instrumentation @aabmass could you please remember me what unique pair you cited in the SIG call? |
Anyway I've added a |
I think I've understood what you meant. The issue is that the process pid is variable while the rest does not change. |
On adding only the recommended is explained there https://opentelemetry.io/docs/specs/semconv/general/attribute-requirement-level/#recommended |
Is your feature request related to a problem?
It would be helpful to have by default the python version of traced services. The python version is contained in
process.runtime
attribute: https://opentelemetry.io/docs/specs/semconv/resource/process/Describe the solution you'd like
Currently the ProcessResourceDetector that is providing the information is not enabled by default but can be enabled via
OTEL_EXPERIMENTAL_RESOURCE_DETECTORS
environment variable.From
opentelemetry-sdk/src/opentelemetry/sdk/resources/__init__.py
:We see that we already enable the OTELResourceDetector even if it the attributes are experimental.
So I'd like to add the ProcessResourceDetector enabled by default with something like:
Describe alternatives you've considered
Alternatively if we are worried that sensitive data may be shared from process args we can add by default only a detector providing the
process.runtime
attributes.Additional context
The text was updated successfully, but these errors were encountered: