Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[inst-rack] rack_events + untraced_endpoints will still emit child spans of those endpoint #962

Closed
robbkidd opened this issue May 3, 2024 · 2 comments · Fixed by #968
Closed
Labels
bug Something isn't working

Comments

@robbkidd
Copy link
Member

robbkidd commented May 3, 2024

Description of the bug

There's a difference in behavior for untraced endpoints when using middleware vs the newer implementation using Rack events.

  • middleware: wraps call with the untraced helper from Utilities which sets untraced in the context used by child spans
  • rack events: early returns from Rack's on_start and on_end handlers but does not change the context, so child spans get traced

I owe more details here! Opening as a placeholder for me to add more later.

@robbkidd robbkidd added the bug Something isn't working label May 3, 2024
@robertlaurin
Copy link
Contributor

#965 (comment)

@robertlaurin
Copy link
Contributor

#968

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants