You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
While using the Go SDK I noticed an inconsistency in how OTEL_RESOURCE_ATTRIBUTES baggage values are encoded and decoded. This was due to a difference in the version of the W3C Baggage spec used for baggage propagation and the OTEL_RESOURCE_ATTRIBUTES decoding.
I haven't parsed the differences between the versions of the W3C spec in question... but if it turns out that the current decoding logic in the baggage text-map propagator is correct then this would be a relatively easy change for us to make (thank you CGI.unescape!).
However, we should wait until the spec change is accepted. Once it is, we can definitely address this. Thank you for the heads-up, I'll add this to our spec-compliance tracking project. ❤️ 🙇
I think the main change is the requirement to percent-decode values. There are some additional considerations about privacy and security but I think they are mostly targeted at end-users.
One interesting thing I noticed is that the W3C spec mandates that the keys must only contain visible ASCII characters (that's why they don't need percent-decoding), but a had a quick glance at the Otel SDKs and none of them seem to enforce this.
👋 This issue has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the keep label to hold stale off permanently, or do nothing. If you do nothing this issue will be closed eventually by the stale bot.
While using the Go SDK I noticed an inconsistency in how
OTEL_RESOURCE_ATTRIBUTES
baggage values are encoded and decoded. This was due to a difference in the version of the W3C Baggage spec used for baggage propagation and theOTEL_RESOURCE_ATTRIBUTES
decoding.open-telemetry/opentelemetry-specification#2670 updates the W3C Baggage spec version used by the Resource spec to require percent-decoding values from
OTEL_RESOURCE_ATTRIBUTES
.The text was updated successfully, but these errors were encountered: