Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor duplication between Traces and Logs #1528

Open
kaylareopelle opened this issue Oct 3, 2023 · 4 comments
Open

Refactor duplication between Traces and Logs #1528

kaylareopelle opened this issue Oct 3, 2023 · 4 comments
Labels

Comments

@kaylareopelle
Copy link
Contributor

Once the Logs SDK and Logs API implementations are stable and ready to be merged into the main API and SDK gems, let's refactor the code for the Trace SDK and API to reduce duplication between the signals.

@fbogsany
Copy link
Contributor

I'm not sure what we've covered in the Logs SDK and API implementations. Note that the Events API is still "experimental", so we don't want to merge that into the main API gem yet. The rest of the Logs API and SDK specs seem to be stable, so we can start to merge them into the main API and SDK gems.

@kaylareopelle
Copy link
Contributor Author

kaylareopelle commented Dec 12, 2023

@fbogsany - The Logs API implementation on main meets the spec. We could release an alpha version on RubyGems, though I’m unsure how valuable that would be without the SDK.

For the Logs SDK, the end-to-end code has been written, but not reviewed. #1517 blocks the other functionality from review. I want to keep the scope of the Logs SDK PRs small and focus on one spec concept at a time. There’s also an OTLP logs exporter and basic instrumentation for Ruby’s logger library awaiting review once the SDK code review is complete.

@kaylareopelle
Copy link
Contributor Author

Update 2023-12-12: During today’s SIG, @robbkidd brought up the rule that you should abstract after you have 3+ of something. With that in mind, this work might begin as part of the Events implementation.

Copy link
Contributor

github-actions bot commented Mar 2, 2024

👋 This issue has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the keep label to hold stale off permanently, or do nothing. If you do nothing this issue will be closed eventually by the stale bot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants