Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zipkin exporter receiving 400 from Open Telemetry Collector #1633

Open
lukegil opened this issue Apr 30, 2024 · 1 comment
Open

Zipkin exporter receiving 400 from Open Telemetry Collector #1633

lukegil opened this issue Apr 30, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@lukegil
Copy link

lukegil commented Apr 30, 2024

Description of the bug

When sending a trace to an otel-collector, the client receives a 400:

json: cannot unmarshal string into Go struct field Endpoint.remoteEndpoint.Port of type uint16

A repro of this issue can be found here:
https://github.com/lukegil/repro-ot-issue

This occurs when a basic "get" is traced, as well as in-the-field cases like when automatically tracing calls to Amazon Cognito.

It appears that the zipkin exporter is explicitly setting port as a string (here, though I could be wrong). Zipkin defines remoteEndpoint.port as being an int.

Share details about your runtime

Operating system details: MacOS 14.1.2 (but also seen on Amz linux)
RUBY_ENGINE: "ruby"
RUBY_VERSION: "3.0.6"
RUBY_DESCRIPTION: "ruby 3.0.6p216 (2023-03-30 revision 23a532679b) [x86_64-darwin22]"

Share a simplified reproduction if possible
https://github.com/lukegil/repro-ot-issue

Thanks for all your work! Let me know if I can help

@lukegil lukegil added the bug Something isn't working label Apr 30, 2024
@xuan-cao-swi
Copy link
Contributor

The port seems expecting int, but zipkin is giving string by looking at the remoteEndpoint from your github repo.

Could you try to change this line to_s to to_i see if can fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants