Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for with_parent to in_span? #936

Closed
ioquatix opened this issue Sep 2, 2021 · 3 comments
Closed

Add support for with_parent to in_span? #936

ioquatix opened this issue Sep 2, 2021 · 3 comments
Labels

Comments

@ioquatix
Copy link

ioquatix commented Sep 2, 2021

def in_span(name, attributes: nil, links: nil, start_timestamp: nil, kind: nil)

This would be very convenient.

@fbogsany
Copy link
Contributor

fbogsany commented Sep 3, 2021

We removed this parameter in #729. You can see the relevant discussion in #703.

@ioquatix
Copy link
Author

ioquatix commented Sep 3, 2021

Thanks for the clarification. It makes sense. I think if there was any action item, it would be adding a link to documentation explaining how to use with_context and how servers should handle external contexts.

Copy link
Contributor

👋 This issue has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the keep label to hold stale off permanently, or do nothing. If you do nothing this issue will be closed eventually by the stale bot.

@github-actions github-actions bot added the stale label Apr 19, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants