Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metrics SDK multi-threaded testing #1601

Open
cijothomas opened this issue Mar 5, 2024 · 0 comments
Open

Metrics SDK multi-threaded testing #1601

cijothomas opened this issue Mar 5, 2024 · 0 comments
Labels
A-metrics Area: issues related to metrics M-sdk

Comments

@cijothomas
Copy link
Member

This was discussed in today's community meeting:

  1. We lack unit testing for Metrics.
  2. We have some module level tests https://github.com/open-telemetry/opentelemetry-rust/blob/main/opentelemetry-sdk/src/metrics/mod.rs that also tests basic scenarios only

We need some tests to orchestrate more complex usage pattern (esp. involving multiple threads updating instruments), and validate that the aggregation is mathematically correct.
Here is an example of such test from OTel .NET (https://github.com/open-telemetry/opentelemetry-dotnet/blob/main/test/OpenTelemetry.Tests/Metrics/MetricApiTestsBase.cs#L1460-L1462)

@bIgBV has agreed to make this happen.

@hdost hdost added A-metrics Area: issues related to metrics M-sdk labels Mar 27, 2024
@hdost hdost added this to the Metrics SDK Stable milestone Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-metrics Area: issues related to metrics M-sdk
Projects
None yet
Development

No branches or pull requests

2 participants