Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Signal feature flag name is not consistent #1710

Open
cijothomas opened this issue May 6, 2024 · 1 comment
Open

Signal feature flag name is not consistent #1710

cijothomas opened this issue May 6, 2024 · 1 comment

Comments

@cijothomas
Copy link
Member

cijothomas commented May 6, 2024 •
edited

https://github.com/open-telemetry/opentelemetry-rust/blob/main/opentelemetry/Cargo.toml#L35

We use "trace", "logs", "metrics". Proposing to make it consistent and rename "trace" to "traces".

https://opentelemetry.io/docs/concepts/signals/
@cijothomas cijothomas changed the title Feature flag name is not consistent Signal feature flag name is not consistent May 6, 2024
@lalitb
Copy link
Member

lalitb commented May 6, 2024 •
edited

We use "trace", "logs", "metrics". Proposing to make it consistent and rename "trace" to "traces".

The namespaces are opentelemetry::trace, opentelemetry_sdk::trace in implementation, so trace actually makes sense from that regards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lalitb @cijothomas