Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify mutability of AggregationTemporality and monotonicity #2250

Closed
cevian opened this issue Jan 7, 2022 · 2 comments · Fixed by #2317
Closed

Clarify mutability of AggregationTemporality and monotonicity #2250

cevian opened this issue Jan 7, 2022 · 2 comments · Fixed by #2317
Assignees
Labels
area:data-model For issues related to data model spec:metrics Related to the specification/metrics directory

Comments

@cevian
Copy link

cevian commented Jan 7, 2022

What are you trying to achieve?

The metric spec says that

Note: The same Resource, name and Attributes but differing point kind coming out of an OpenTelemetry SDK is considered an "error state" that SHOULD be handled by an SDK.

I'd like some clarification about fields like aggregation_temporality and is_monotonic are those fields allowed to change values with the same "stream" (same Resource, name and Attributes) or is there some guarantee on consistency there as well.

In my mind it's very strange if a stream changes either of those fields in the middle, but maybe there are some use cases that require this?

@cevian cevian added the spec:metrics Related to the specification/metrics directory label Jan 7, 2022
@reyang reyang added the area:data-model For issues related to data model label Jan 11, 2022
@jmacd
Copy link
Contributor

jmacd commented Feb 4, 2022

I fixed this, to some degree, in #2317.
Neither should change mid-stream, however duplicate instrument registration conflicts could lead to a mixture of values for the what looks like the same metric name.

@bogdandrutu
Copy link
Member

@jmacd @cevian there are scenarios where this may happen, in cases where a restart happens to the app. A restart does not necessary mean a change in the Resource/Attribute etc. There are ways to detect stream restart like the start_time in the points, or a previous staleness point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:data-model For issues related to data model spec:metrics Related to the specification/metrics directory
Projects
None yet
4 participants