Alignment with OpenTelemetry Collector configuration #3963
Assignees
Labels
Comments
|
@mx-psi I assigned this to you since you are already working on it. |
|
@mx-psi @open-telemetry/configuration-maintainers what do you think of moving this meta issue to https://github.com/open-telemetry/opentelemetry-configuration? EDIT oops! I see @jack-berg just transferred it here |
|
Yeah i think since this concerns the file config spec, and the not the file config model / schema, it belongs in this repo. Some day, we might consider moving the file config schema to |
This was referenced Apr 2, 2024
jack-berg
added a commit
that referenced
this issue
Apr 8, 2024
…bstitution (#3974) Fixes #3961 ## Changes Allows for the usage of the `${env:ENV}` syntax in SDK file configuration. This syntax is used in the OpenTelemetry Collector, see https://opentelemetry.io/docs/collector/configuration/#environment-variables for more information. This does not mean that other providers need to be supported; if we want to allow this we would need to reserve that syntax by rejecting `${<provider>:URI}` as invalid, since right now it would be left as-is. * [x] Related issues #3961, part of #3963 --------- Co-authored-by: jack-berg <34418638+jack-berg@users.noreply.github.com>
jack-berg
added a commit
that referenced
this issue
May 7, 2024
…ollow (#3973) Fixes #3962 ## Changes Specifies the YAML schema to follow. A schema is a set of YAML tags (i.e. types) and a way to assign types. YAML 1.2 recommends the 'Core schema': the types are those of JSON. Scalars are resolved as one would expect, see [here](https://yaml.org/spec/1.2.2/#103-core-schema) for the details. One important difference with the way that YAML 1.1 used to work is that integer scalars starting with a `0` are interpreted as being written in decimal notation; e.g. `0123` parses to the integer 123 instead of the integer 83 (you can still use octal notation in YAML 1.2 by using `0o123`). Some YAML parsers deviate from the core schema in how this works, for example, both of the more commonly used YAML parsing libraries in Golang parse `0123` as 83 ([go-yaml/yaml](https://github.com/go-yaml/yaml?tab=readme-ov-file#compatibility) and [goccy/go-yaml](https://github.com/goccy/go-yaml/blob/4653a1bb5c0047bb37280ac341e2f091cb44352f/ast/ast.go#L326)). **This may make it a bit difficult to strictly follow this requirement in some languages**. For non-trivial changes, follow the [change proposal process](https://github.com/open-telemetry/opentelemetry-specification/blob/main/CONTRIBUTING.md#proposing-a-change). * [x] Related issues #3962, part of #3963 --------- Co-authored-by: Robert Pająk <pellared@hotmail.com> Co-authored-by: jack-berg <34418638+jack-berg@users.noreply.github.com>
jack-berg
pushed a commit
that referenced
this issue
May 8, 2024
Updates #3959 ## Changes Adds example for using an integer in hexadecimal notation. The intention is to show the difference when quoting vs not quoting and make explicit that quoting means keeping the original representation (we already have the `true` example but this one has two different representations). I think this is already implied by the text so this is only a change in the example. * [x] Related issues #3959, part of #3963 --------- Co-authored-by: Robert Pająk <pellared@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I am working on stabilizing the Collector configuration resolution and environment variable support as part of https://github.com/open-telemetry/opentelemetry-collector/milestone/32.
One of my goals is to bring the File Configuration feature in SDKs and the Collector configuration features to be as similar as possible: it is likely that there will be significant overlap between people writing Collector configurations and people writing SDK configurations.
This is intended to be a meta-issue tracking separate issues that affect Collector and SDK compatibility:
${env:ENV}syntax #3961The text was updated successfully, but these errors were encountered: