Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NextAcroiss variable assignment error #7

Open
rbarillot opened this issue May 14, 2020 · 2 comments
Open

NextAcroiss variable assignment error #7

rbarillot opened this issue May 14, 2020 · 2 comments
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@rbarillot
Copy link
Collaborator

appears that the variable NextAcroiss could be referenced befor assignement. See complete description #here: traquet#1 (comment)

@rbarillot rbarillot added bug Something isn't working good first issue Good for newcomers labels May 14, 2020
@dicombes dicombes reopened this May 26, 2020
@dicombes
Copy link
Collaborator

dicombes commented May 26, 2020

The problem was due to unrealistic conditions making a NextAcroiss assignment error. Although NextAcroiss should be always assigned in standard conditions we will rise an error to get a more explicit message.

@rbarillot
Copy link
Collaborator Author

rbarillot commented Jul 23, 2020

Here is an overview of the code that leads to the error:

if leaf non-mature:

  • if sheath < previous sheath +13:

    • if leaf is hidden:
      NextAcroiss calculated from FoncCroiss

    • if leaf is visible:
      NextAcroiss calculated from FoncCroiss

  • if sheath > 0.98 x final sheath length AND sheath <= previous sheath - 5 AND leaf is hidden
    NextAcroiss = 1

  • if sheath >= previous sheath +13 AND leaf is visible
    NextAcroiss = 0`

When NextAcroiss is not defined, it means that the sheath is longer that the previous one but the leaf has not emerged. This situation seems unlikely. We should look for the reasons leading to such a long leaf that its sheaths become longer than the previous one before emergence. Or the issue is caused by the previous sheath that is too short
@SimonRouet could you check for that please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants