Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OOTB support for HF models #86

Open
2 tasks
heyselbi opened this issue Sep 14, 2023 · 5 comments
Open
2 tasks

OOTB support for HF models #86

heyselbi opened this issue Sep 14, 2023 · 5 comments
Assignees
@heyselbi
Labels
kind/feature New feature req From the Requirements document

Comments

@heyselbi
Copy link

heyselbi commented Sep 14, 2023 •
edited

From req doc: 2d
P0: Users must be able to serve models from Hugging Face without having to do any additional conversions or configurations

Acceptance criteria:

  • Test TGIS image with HF model
  • Share instructions
@heyselbi heyselbi mentioned this issue Sep 27, 2023
Closed
@heyselbi
Copy link
Author

heyselbi commented Oct 5, 2023

Related to TGIS/Caikit split

@heyselbi heyselbi added req From the Requirements document rhods-2.5 labels Oct 12, 2023
@heyselbi heyselbi added the kind/feature New feature label Oct 23, 2023
@heyselbi heyselbi assigned heyselbi and unassigned Xaenalt and dtrifiro Oct 26, 2023
@heyselbi
Copy link
Author

TGIS image is ready to be tested with HF models.

@heyselbi heyselbi removed the rhods-2.5 label Nov 8, 2023
@bdattoma
Copy link

bdattoma commented Nov 8, 2023

@heyselbi I'll use the ServingRuntime definition from https://github.com/opendatahub-io/caikit-tgis-serving/pull/132/files. Is that correct?

@heyselbi
Copy link
Author

heyselbi commented Nov 8, 2023

@bdattoma that is correct. Let me know if you run into any issues.

@bdattoma
Copy link

@bdattoma that is correct. Let me know if you run into any issues.

okay thanks. I'll defer testing this since this ticket got removed from 2.5. I'll be back on it after 2.5

Jooho pushed a commit to Jooho/kserve that referenced this issue Jan 11, 2024
@openshift-merge-robot
Merge pull request opendatahub-io#86 from heyselbi/update-bootstrap
dfac4bb 
Update model conversion instructions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@heyselbi heyselbi

Labels
kind/feature New feature req From the Requirements document
Projects
Internal tracking
Status: No status
ODH Feature Tracking
Status: No status
ODH Model Serving Planning
Status: To-do/Groomed
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Xaenalt @dtrifiro @heyselbi @bdattoma