Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[model-controller] Create ServingEnvironment in MR based on namespace containing ServingRuntime CRs #174

Open
Tracked by #173
lampajr opened this issue Nov 20, 2023 · 2 comments
Assignees
Labels

Comments

@lampajr
Copy link
Contributor

lampajr commented Nov 20, 2023

Is your feature request related to a problem? Please describe.
First step in sequence diagram is to monitor ServingRuntime CRs and create the corresponding ServingEnvironment instance in the Model Registry, the serving runtime name will be the namespace where the watched ServingRuntime CRs are located.

Describe the solution you'd like
Create a new reconciler in the odh-model-controller monitoring for the ServingRuntime CRs and update the model registry accordingly by creating new ServingEnvironment records if not already existing.

Describe alternatives you've considered
n/a

Additional context
n/a

@dhirajsb
Copy link
Contributor

@lampajr Should the title be changed, since Environments don't map to model serving runtimes, rather to a namespace that contains runtimes?

@lampajr lampajr changed the title [model-controller] Create ServingEnvironment in MR based on ServingRuntime CRs [model-controller] Create ServingEnvironment in MR based on namespace containing ServingRuntime CRs Nov 22, 2023
@lampajr
Copy link
Contributor Author

lampajr commented Nov 22, 2023

@lampajr Should the title be changed, since Environments don't map to model serving runtimes, rather to a namespace that contains runtimes?

You are right, title updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: In Progress
Status: No status
Development

Successfully merging a pull request may close this issue.

2 participants