-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bring Metadata Library back! #211
Comments
I think this will be of convenience as we will eventually modify our entities (eg ModelArtifact) for instance to add new fields etc.
On other hands, as explained in the meeting, this won't necessarily detect other types of misalignment such as https://github.com/opendatahub-io/model-registry/issues/206 Based on these, I would conclude this is important but not our top priority atm; unless I missed something! |
I think centralizing the MLMD types setup will avoid issues like https://github.com/opendatahub-io/model-registry/issues/204 Given that IMO the crucial point here is more on the testing part:
I am just thinking loud here, so haapy to hear other proposals or considerations. |
@lampajr summarized it correctly. Basically, use the library as the source of truth for schema where possible, either directly or using source generated from the library. |
Is your feature request related to a problem? Please describe.
Since both Python client and Go service library share the schema models for mlmd types, there should be only one source of truth for creating/using types and for testing.
Describe the solution you'd like
Bring back the
yaml
metadata library definitions and mapper from the older GraphQL code base to restore the metadata library feature.The library can be used for:
Describe alternatives you've considered
Keeping ml metadata schema synced in separate Go and Python codes and tests is not maintainable in the long run as the number of types increase.
Additional context
None
The text was updated successfully, but these errors were encountered: