Skip to content
This repository has been archived by the owner on May 24, 2022. It is now read-only.

Broken building on Linux in development since PR that updated Fether to use Electron 5 #524

Open
ltfschoen opened this issue May 25, 2019 · 2 comments

Comments

@ltfschoen
Copy link
Contributor

ltfschoen commented May 25, 2019

When I run the latest Fether 'master' branch on Debian, it shows the following error in the terminal when it's launching

[start-electron] ┗ ----------------------------
[start-react   ] Starting the development server...
[start-react   ] 
[start-electron] ┏ Electron -------------------
[start-electron] 
[start-electron]   [3887:0525/041114.156447:FATAL:setuid_sandbox_host.cc(157)] The SUID sandbox helper binary was found, but is not configured correctly. Rather than run without sandboxing I'm aborting now. You need to make sure that /home/yourusername/code/github/paritytech/fether/node_modules/electron/dist/chrome-sandbox is owned by root and has mode 4755.
[start-electron] 
[start-electron] ┗ ----------------------------
[start-react   ] Compiled successfully!

And it no longer automatically opens the Fether window. I have to manually go to localhost:3000 in my browser, where it just displays "Launching the node...".

And when I view the error messages in Console of the Chrome Browser Inspector, it shows error:

Refused to load manifest from 'http://localhost:3000/manifest.json' because it violates the following Content Security Policy directive: "manifest-src 'none'".

But if I checkout an older commit (prior to the "Upgrade to electron 5" PR (#522) commit 70b339b) then it automatically opens the Fether window successfully like it used to in development environment, where you just have to "refresh" the Fether window for the accounts page to appear.

Are there additional steps that were documented somewhere that developers on Linux and/or Windows need to follow to make it work since this commit (i.e. to overcome the errors shown above)?

@ltfschoen
Copy link
Contributor Author

I found that /home/yourusername/code/github/paritytech/fether/node_modules/electron/dist/chrome-sandbox had permissions '-rwxr-xr-x'. I just followed the recommendations in the Electron error message and it worked as before

sudo chown root /path/to/fether/node_modules/electron/dist/chrome-sandbox
sudo chmod 4755 /path/to/fether/node_modules/electron/dist/chrome-sandbox

@ltfschoen ltfschoen changed the title Broken on Linux since PR that updated Fether to use Electron 5 Broken on Linux in development since PR that updated Fether to use Electron 5 May 25, 2019
@ltfschoen ltfschoen changed the title Broken on Linux in development since PR that updated Fether to use Electron 5 Broken building on Linux in development since PR that updated Fether to use Electron 5 May 25, 2019
@axelchalon
Copy link
Contributor

axelchalon commented May 27, 2019

Can reproduce on ArchLinux on master with yarn start and on the v0.3.1 AppImage release
edit: @Tbaut doesn't have this error though

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants