Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump reactive dependencies. #1105

Merged
merged 1 commit into from Nov 18, 2019
Merged

Bump reactive dependencies. #1105

merged 1 commit into from Nov 18, 2019

Conversation

SimY4
Copy link
Contributor

@SimY4 SimY4 commented Nov 3, 2019 •
edited

Make reactive contract work with the latest project reactor class hierarchy.

UPD: related change in project reactor: reactor/reactor-core#1527

velo
velo approved these changes Nov 4, 2019
View reviewed changes
Copy link
Member

@velo velo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Liked the change. Fwiw, you can override dependencies W/o waiting on feign release

@SimY4
Copy link
Contributor Author

SimY4 commented Nov 4, 2019 •
edited

@velo I can, but the problem here is that the current version of reactive extensions will not work with the latest projectreactor release. They've changed their class hierarchy and added an extra layer between Mono and Publisher interface. So direct interface lookup is failing. I changed the logic to check not only direct interfaces but whether the class is an instance of Publisher in general.

velo
velo approved these changes Nov 4, 2019
View reviewed changes
Copy link
Member

@velo velo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@velo velo added enhancement For recommending new capabilities ready to merge Will be merged if no other member ask for changes labels Nov 4, 2019
@SimY4
Bump reactive dependencies.
27ef3e8 
Make reactive contract work with the latest project reactor class hierarchy.
@SimY4
Copy link
Contributor Author

SimY4 commented Nov 18, 2019

Can this be merged in? and released? This is currently blocking the spring boot upgrade for us.

@velo velo merged commit 7c6b2bb into OpenFeign:master Nov 18, 2019
@dependabot dependabot bot mentioned this pull request Mar 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@velo velo velo approved these changes

Assignees
No one assigned
Labels
enhancement For recommending new capabilities ready to merge Will be merged if no other member ask for changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SimY4 @velo