Force followRedirects on the OkHttpClient when needed #1130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdavisk6
added
bug
|
Looks good. Travis is unhappy due to formatting being off. Can you please fix the formatting? |
fpavageau
force-pushed
the
fix-follow-redirects
branch
from
2820a69
to
224556c
Compare
fpavageau
force-pushed
the
fix-follow-redirects
branch
from
224556c
to
92c4e1f
Compare
|
@kdavisk6 Sure, it's fixed. Too bad the formatting check is attached to the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small fix:
followRedirectswas only applied when combined with a connect or read timeout override, which the test did.