Ensure Iterable values are encoded before template expansion #1138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes OpenFeign#1123, Fixes OpenFeign#1133, Fixes OpenFeign#1102, Fixes OpenFeign#1028 Ensures that all expressions are fully-encoded before being manipulated during template expansion. This allows parameters to include reserved values and result in properly encoded results. Additionally, `Iterable` values are now handled in accordance with RFC 6570 allowing for the specified `CollectionFormat` to be applied and empty parameters to be expanded correctly as this is the main use case that exhibited this issue.
This was referenced Dec 26, 2019
…gn#1140) * Ensure all brackets are decoded in JSON based Body Templates Fixes OpenFeign#1129 When JSON is detected in a Body Template, all start and end tokens that may have been pct-encoded are decoded, ensuring that the expanded result is valid JSON.
Fixes OpenFeign#1036 Relaxed the regular expression used to determine if an expression is valid to support additional expression variable names. We will no longer restrict what an expression name can be.
Fixes OpenFeign#1123, Fixes OpenFeign#1133, Fixes OpenFeign#1102, Fixes OpenFeign#1028 Ensures that all expressions are fully-encoded before being manipulated during template expansion. This allows parameters to include reserved values and result in properly encoded results. Additionally, `Iterable` values are now handled in accordance with RFC 6570 allowing for the specified `CollectionFormat` to be applied and empty parameters to be expanded correctly as this is the main use case that exhibited this issue.
…hub.com/kdavisk6/feign into OpenFeigngh-1123-correct-list-expansion
This was referenced Dec 27, 2019
kdavisk6
added a commit
to kdavisk6/feign
that referenced
this pull request
Jan 17, 2020
Fixes OpenFeign#1156 Collection Format was encoding query string values unnecessarily due to changes introduced in OpenFeign#1138 and OpenFeign#1139 that encode template values before appending them to the query string. In addition, `decodeSlash` flags that were accidentally removed, have been restored in QueryTemplate.
kdavisk6
added a commit
to kdavisk6/feign
that referenced
this pull request
Jan 18, 2020
Fixes OpenFeign#1156 Collection Format was encoding query string values unnecessarily due to changes introduced in OpenFeign#1138 and OpenFeign#1139 that encode template values before appending them to the query string. In addition, `decodeSlash` flags that were accidentally removed, have been restored in QueryTemplate.
kdavisk6
added a commit
that referenced
this pull request
Jan 18, 2020
Fixes #1156 Collection Format was encoding query string values unnecessarily due to changes introduced in #1138 and #1139 that encode template values before appending them to the query string. In addition, `decodeSlash` flags that were accidentally removed, have been restored in QueryTemplate. * Restoring decodeSlash in QueryTemplate * Correcting Readme with regards to decodeSlash usage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1123, Fixes #1133, Fixes #1102, Fixes #1028, Fixes #1096, Fixes #1087, Fixes #1064
Ensures that all expressions are fully-encoded before being
manipulated during template expansion. This allows parameters
to include reserved values and result in properly encoded
results.
Additionally,
Iterablevalues are now handled in accordancewith RFC 6570 allowing for the specified
CollectionFormattobe applied and empty parameters to be expanded correctly as this
is the main use case that exhibited this issue.